Minor client improvement: alt-click to turn
Posted: Tue Oct 03, 2017 11:01 pm
Hi,
After the great feature of PlayerLookAt was introduced, I've found it somewhat hard to use because you have to double-click a player and if you miss the avatar then you end up running around like a freak.
So i thought that maybe holding some key would prevent you from walking. And it seems that having alt-click to turn your char instead of walking is consistent with alt-arrow for turning.
And then I thought that it could be a fine task for a noob like me to implement, so I did that and opened a pull-request. The goal of the changes is:
- Alt-click on tile or item or avatar would only turn towards the target.
- Alt-double-click another player would still open naming/lookAt dialog.
I'm not quite sure about the correct procedure. Should I have opened mantis bug? Consult the developers before implementing?
In any case I would appreciate feedback on the idea and the implementation.
After the great feature of PlayerLookAt was introduced, I've found it somewhat hard to use because you have to double-click a player and if you miss the avatar then you end up running around like a freak.
So i thought that maybe holding some key would prevent you from walking. And it seems that having alt-click to turn your char instead of walking is consistent with alt-arrow for turning.
And then I thought that it could be a fine task for a noob like me to implement, so I did that and opened a pull-request. The goal of the changes is:
- Alt-click on tile or item or avatar would only turn towards the target.
- Alt-double-click another player would still open naming/lookAt dialog.
I'm not quite sure about the correct procedure. Should I have opened mantis bug? Consult the developers before implementing?
In any case I would appreciate feedback on the idea and the implementation.